Skip to content

feat: add C implementation for stats/base/dists/erlang/mgf#8754

Merged
Planeshifter merged 9 commits intostdlib-js:developfrom
Neerajpathak07:erlang-mgf
Jan 12, 2026
Merged

feat: add C implementation for stats/base/dists/erlang/mgf#8754
Planeshifter merged 9 commits intostdlib-js:developfrom
Neerajpathak07:erlang-mgf

Conversation

@Neerajpathak07
Copy link
Copy Markdown
Member

@Neerajpathak07 Neerajpathak07 commented Dec 3, 2025

Resolves #3573.

Description

What is the purpose of this pull request?

This pull request:

  • Adds C implementation for stats/base/dists/erlang/mgf

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. labels Dec 3, 2025
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Dec 3, 2025 •
edited
Loading

Coverage Report

No coverage information available.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review December 3, 2025 17:41
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 3, 2025
@Neerajpathak07 Neerajpathak07 added the C Issue involves or relates to C. label Dec 22, 2025
Planeshifter
Planeshifter reviewed Jan 8, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some initial comments.

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jan 8, 2026
@Neerajpathak07
Copy link
Copy Markdown
Member Author

Neerajpathak07 commented Jan 8, 2026

@Planeshifter updated with suggested changes!!

@Neerajpathak07
Copy link
Copy Markdown
Member Author

Neerajpathak07 commented Jan 8, 2026

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 8, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Jan 8, 2026

/stdlib update-copyright-years

@Neerajpathak07, the slash command failed to complete. Please check the workflow logs for details.

View workflow run

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 8, 2026
@Neerajpathak07
Copy link
Copy Markdown
Member Author

Neerajpathak07 commented Jan 8, 2026

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 8, 2026
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 8, 2026
@Neerajpathak07
Copy link
Copy Markdown
Member Author

Neerajpathak07 commented Jan 8, 2026

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 8, 2026
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 8, 2026
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 8, 2026
Planeshifter
Planeshifter reviewed Jan 12, 2026
View reviewed changes
@Planeshifter
chore: minor clean-up
8f57e04 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter approved these changes Jan 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in! 🚀

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jan 12, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Jan 12, 2026

PR Commit Message

feat: add C implementation for `stats/base/dists/erlang/mgf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/8754
Closes: https://github.com/stdlib-js/stdlib/issues/3573

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Jan 12, 2026
@Planeshifter Planeshifter merged commit 521f824 into stdlib-js:develop Jan 12, 2026
32 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Jan 12, 2026
nakul-krishnakumar pushed a commit to nakul-krishnakumar/stdlib that referenced this pull request Jan 25, 2026
@Neerajpathak07 @Planeshifter
@stdlib-bot @nakul-krishnakumar
feat: add C implementation for stats/base/dists/erlang/mgf
307d3b5 
PR-URL: stdlib-js#8754
Closes: stdlib-js#3573

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

C Issue involves or relates to C. Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/erlang/mgf

3 participants

@Neerajpathak07 @stdlib-bot @Planeshifter